Skip to content

chore: enable all steps in cargo deny except advisories in fast CI#2098

Merged
gilcu3 merged 2 commits intomainfrom
2096-re-enable-cargo-deny-in-fast-ci-where-it-makes-sense
Feb 16, 2026
Merged

chore: enable all steps in cargo deny except advisories in fast CI#2098
gilcu3 merged 2 commits intomainfrom
2096-re-enable-cargo-deny-in-fast-ci-where-it-makes-sense

Conversation

@gilcu3
Copy link
Contributor

@gilcu3 gilcu3 commented Feb 16, 2026

Closes #2096

@gilcu3 gilcu3 linked an issue Feb 16, 2026 that may be closed by this pull request
@claude
Copy link

claude bot commented Feb 16, 2026

PR Review - Critical Issue Found

INCORRECT COMMAND SYNTAX in Makefile.toml line 112

The cargo-deny-no-advisories task has incorrect argument ordering. The check subcommand must come immediately after deny, with flags like --all-features following the subcommand.

Current: args = [deny, --all-features, check, licenses, bans, sources]
Should be: args = [deny, check, --all-features, licenses, bans, sources]

The current ordering will cause the command to fail when check-all-fast runs in CI.

Otherwise, the PR correctly addresses issue 2096 by enabling non-time-dependent cargo-deny checks in fast CI.

Needs fix before merge

@gilcu3 gilcu3 force-pushed the 2096-re-enable-cargo-deny-in-fast-ci-where-it-makes-sense branch from 61b5a20 to df31edc Compare February 16, 2026 08:14
@gilcu3
Copy link
Contributor Author

gilcu3 commented Feb 16, 2026

The current ordering will cause the command to fail when check-all-fast runs in CI.

Sorry bot but that is not correct, CI works just fine. Furthermore see

❯ cargo deny --help
Cargo plugin to help you manage large dependency graphs

Usage: cargo-deny [OPTIONS] <COMMAND>

Commands:
  check  Checks a project's crate graph
  fetch  Fetches remote data
  init   Creates a cargo-deny config from a template
  list   Outputs a listing of all licenses and the crates that use them
  help   Print this message or the help of the given subcommand(s)

@gilcu3 gilcu3 force-pushed the 2096-re-enable-cargo-deny-in-fast-ci-where-it-makes-sense branch from df31edc to 2d9874a Compare February 16, 2026 08:17
@gilcu3 gilcu3 enabled auto-merge February 16, 2026 08:28
@gilcu3 gilcu3 added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit fb7b80c Feb 16, 2026
9 checks passed
@gilcu3 gilcu3 deleted the 2096-re-enable-cargo-deny-in-fast-ci-where-it-makes-sense branch February 16, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

re-enable cargo-deny in fast CI where it makes sense

3 participants