Conversation
PR Review - Critical Issue FoundINCORRECT COMMAND SYNTAX in Makefile.toml line 112 The cargo-deny-no-advisories task has incorrect argument ordering. The check subcommand must come immediately after deny, with flags like --all-features following the subcommand. Current: args = [deny, --all-features, check, licenses, bans, sources] The current ordering will cause the command to fail when check-all-fast runs in CI. Otherwise, the PR correctly addresses issue 2096 by enabling non-time-dependent cargo-deny checks in fast CI. Needs fix before merge |
61b5a20 to
df31edc
Compare
Contributor
Author
Sorry bot but that is not correct, CI works just fine. Furthermore see |
df31edc to
2d9874a
Compare
netrome
approved these changes
Feb 16, 2026
DSharifi
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2096