Skip to content

ci: Dependabot with exceptions#2100

Merged
DSharifi merged 4 commits intomainfrom
simon/dependabot
Feb 16, 2026
Merged

ci: Dependabot with exceptions#2100
DSharifi merged 4 commits intomainfrom
simon/dependabot

Conversation

@SimonRastikian
Copy link
Contributor

@SimonRastikian SimonRastikian commented Feb 16, 2026

Closes #2016

I find it a little concerning that I had to add this many exceptions in upgrades.

@claude
Copy link

claude bot commented Feb 16, 2026

Code Review

I've reviewed the Dependabot configuration. This looks good overall - all the ignored dependencies have corresponding comments in Cargo.toml explaining why they can't be upgraded.

Configuration Analysis

The ignored dependencies align with the TODO comments and pinning notes in Cargo.toml:

Minor Suggestions (non-blocking)

  1. Target branch is redundant: The target-branch: "main" setting is the default and can be omitted.

  2. Cooldown parameter: The cooldown.default-days: 7 with weekly schedule means Dependabot will check weekly but wait 7 days after rejection before re-proposing. This is sensible but consider if you want this behavior (some teams prefer immediate re-proposals on weekly checks).

  3. Documentation: Consider adding a comment in this file pointing to the Cargo.toml comments explaining each exception, e.g.:

    # See Cargo.toml [workspace.dependencies] for explanations of ignored dependencies

The PR author's concern about "many exceptions" is understandable, but each one is justified by technical constraints documented in the codebase. This is a pragmatic approach for maintaining dependency hygiene while respecting the project's technical constraints.

Approved - No critical issues. The configuration is safe and aligns with documented dependency constraints.

@SimonRastikian SimonRastikian changed the title feat: Dependabot with exceptions CI: Dependabot with exceptions Feb 16, 2026
@gilcu3
Copy link
Contributor

gilcu3 commented Feb 16, 2026

Closes #2099

I find it a little concerning that I had to add this many exceptions in upgrades.

It took me some time to learn, but the PR title should be: ci: added support for Dependabot with exceptions or something similar. feat is only used for new features (that ship in the mpc-node binary for example)

@SimonRastikian SimonRastikian changed the title CI: Dependabot with exceptions ci: Dependabot with exceptions Feb 16, 2026
@SimonRastikian
Copy link
Contributor Author

Haha done it before I saw the message :)

gilcu3
gilcu3 previously approved these changes Feb 16, 2026
Copy link
Contributor

@gilcu3 gilcu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SimonRastikian SimonRastikian added this pull request to the merge queue Feb 16, 2026
Copy link
Contributor

@DSharifi DSharifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run the action manually once so we can see it works before merging?

@DSharifi DSharifi removed this pull request from the merge queue due to a manual request Feb 16, 2026
@DSharifi DSharifi added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit 7d157aa Feb 16, 2026
10 checks passed
@DSharifi DSharifi deleted the simon/dependabot branch February 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce automated dependency updates

4 participants