chore(nix): add jq and ruff to dev shell packages#2144
Merged
Conversation
|
Minor issue: duplicate python311Packages.keyring entry in pythonTools (flake.nix lines 140-141). One should be removed. No blocking issues otherwise. Approved. |
SimonRastikian
previously approved these changes
Feb 18, 2026
Contributor
SimonRastikian
left a comment
SimonRastikian
left a comment
There was a problem hiding this comment.
Approval.
When I tried searching for a solution, I did not have this in mind. Good that I pinged you :)
gilcu3
approved these changes
Feb 18, 2026
| pythonTools = with pkgs; [ | ||
| python311 | ||
| python311Packages.keyring | ||
| ruff # linter and formatter |
Contributor
There was a problem hiding this comment.
nit: to be on the safe side, we should use the same version as in CI. I remember a ruff change causing some issues a few months ago
SimonRastikian
approved these changes
Feb 18, 2026
Contributor
SimonRastikian
left a comment
SimonRastikian
left a comment
There was a problem hiding this comment.
Did not test it yet locally but looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2143