Conversation
Review: PR #21551. Shell command injection via PR title (High)
echo "PR TITLE: $PR_TITLE"Double-quoted strings in bash interpret and the shell will execute the subshell expansion before echoing. This is a command injection vulnerability. The Fix: Use printf 'PR TITLE: %s\n' "$PR_TITLE"2. Heredoc delimiter injection via PR title (Medium)Same line — if a PR title contains the literal text Fix: Use a more unique/random delimiter, and still apply the 3.
|
There was a problem hiding this comment.
Pull request overview
Adds an additional CI check to help keep squash-merge commit history/changelog clean by ensuring PR titles use an appropriate Conventional Commit type based on the files changed (per Issue #2154).
Changes:
- Adds a
check-pr-title-typejob to the existing PR title lint workflow. - Builds an LLM prompt containing PR title + changed file list and runs
anthropics/claude-code-actionto decide whether to comment with a suggested type. - Introduces a prompt file defining the classification rules and expected behavior/output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/pr-title-lint.yml |
Adds the new non-blocking title-type validation job using Claude and gh to comment. |
.github/prompts/pr-title-check.prompt.md |
Defines the rules and output format for deciding whether the PR title type matches changed files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…t-type-matches-changed-files
…t-type-matches-changed-files
…t-type-matches-changed-files
|
Nit: |
Ah, that was part of the tests — forgot to revert it. Thanks! 😄 |
Fixes #2154