chore: add startup logging to start-with-config-file path#2709
Merged
barakeinav1 merged 1 commit intomainfrom Apr 7, 2026
Merged
chore: add startup logging to start-with-config-file path#2709barakeinav1 merged 1 commit intomainfrom
barakeinav1 merged 1 commit intomainfrom
Conversation
|
Code Review: No critical issues found Clean, minimal change that adds useful startup logging right after logging initialization. The logged fields (account ID, contract ID, home dir, web UI address, TEE authority, image hash, NEAR init config) are all operational metadata appropriate for logs — no secrets or sensitive data exposed. ✅ Approved |
Log version, account, contract, TEE authority, and NEAR init config at startup before the attestation attempt. This provides context for debugging when the node crashes early. Closes #2708
barakeinav1
force-pushed
the
barak/startup-logging
branch
from
5759ec1 to
45c9e96
Compare
kevindeforth
approved these changes
Apr 7, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Apr 8, 2026
Co-authored-by: netrome <22524681+netrome@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
start-with-config-filecode path (used by the Rust launcher) had minimal logging at startup. When the node crashed on attestation, there was no context about version, config, or TEE mode.Adds startup logs:
These appear immediately after logging is initialized, before the attestation attempt.
Closes #2708
Test plan