refactor: replace tee launcher hash votes with generics#2930
Closed
kevindeforth wants to merge 5 commits into
Closed
refactor: replace tee launcher hash votes with generics#2930kevindeforth wants to merge 5 commits into
kevindeforth wants to merge 5 commits into
Conversation
kevindeforth
force-pushed
the
kd/replace-tee-votes-with-generics
branch
from
c24b66a to
8123f07
Compare
kevindeforth
changed the title
kevindeforth
force-pushed
the
kd/1573-mpc-contract-introduce-generic-voting-struct
branch
from
0efb84e to
6a579df
Compare
kevindeforth
force-pushed
the
kd/replace-tee-votes-with-generics
branch
from
8123f07 to
e63ed93
Compare
Contributor
Author
|
Looking at this, I think we can simplify a bit by getting rid of the So, while currently we have:
It would probably be enough to simply use:
If the proposal is small or already a hash (such as for some proposals of the TEE state), we can store the proposal directly:
|
Contributor
Author
|
closing this in favor of #2935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft, to showcase how to use the abstract voting structs.
Follow-up to #2739
Currently failing due to:
ParticipantId. To be addressed before merge.