refactor(fix): relocate bench_utils ckd functions#3634
Conversation
Pull request overviewPure refactor: relocates Changes:
Reviewed changesPer-file summary
FindingsVerified:
No blocking issues. No non-blocking nits worth raising — the change is mechanical and tightly scoped. ✅ Approved |
There was a problem hiding this comment.
Pull request overview
Refactors the threshold-signatures benchmark utilities by moving CKD-specific helpers out of the FROST/EdDSA bench-utils module into a dedicated CKD bench-utils module, aligning bench helpers with their respective protocols.
Changes:
- Removed
prepare_ckdandPreparedCkdPackagefrombench_utils/frost_eddsa.rs. - Added a new
bench_utils/ckd.rscontaining the CKD bench preparation helpers. - Registered and re-exported the new
ckdmodule frombenches/bench_utils.rsso existing bench consumers can continue importing fromcrate::bench_utils.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/threshold-signatures/benches/bench_utils/frost_eddsa.rs | Removes CKD bench helpers that don’t belong to the FROST/EdDSA bench-utils module. |
| crates/threshold-signatures/benches/bench_utils/ckd.rs | Introduces a dedicated CKD bench-utils module containing prepare_ckd and PreparedCkdPackage. |
| crates/threshold-signatures/benches/bench_utils.rs | Registers bench_utils/ckd.rs and re-exports its public items via pub use ckd::*;. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #3633