Conversation
barakeinav1
reviewed
Jun 26, 2025
| cat <<EOF > "$1" | ||
| # Configuration File | ||
| my_near_account_id: $MPC_ACCOUNT_ID | ||
| near_responder_account_id: $responder_id |
Contributor
There was a problem hiding this comment.
I'm not sure it matters,
but lets use upper case values the same as the rest of the env variables.
Collaborator
Author
There was a problem hiding this comment.
It's not an env variable no more, it's a script variable. One have an option of passing $MPC_RESPONDER_ID
Contributor
There was a problem hiding this comment.
can I pass this via env variable $MPC_RESPONDER_ID?
barakeinav1
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #445 we generate responder keys inside a node, thus we no longer read values from
respond.yamlconfig, that was supplying the keys and the responder account id.Responder account id field migrated into
config.yaml.This PR brings back default behaviour when responder id wasn't specified + sets the value in the config