chore(lazy_static): replace lazy_static with LazyLock #660
Conversation
This reverts commit 3c0caa0.
|
Thank you @hackpk - you need to rebase on latest main though since there are some conflicts. |
hackpk
changed the title
hackpk
changed the title
hackpk
changed the title
|
Hey! How come you reverted the removal of |
|
Hi @netrome, it got removed while reverting made the changes again please check? Can you please be my mentor? I want be better at this ? |
|
Okay looks better now but formatting seems off. Did you run |
I can help with PR comments, but don't have capacity to provide any fully-fledged mentorship right now. I know this type of external contribution can be hard, but cannot help you more unfortunately. |
|
@netrome that's okay thanks btw and yes ran fmt but again after reverting I think I missed I will run it again thanks for your patience though |
No worries. There's been a new metric added on master though, so you'll need to rebase on latest master (or merge) and update the PR to include the new metric as well. |
kevindeforth
changed the title
| #[allow(dead_code)] | ||
| pub static MPC_ACCESS_KEY_NONCE: LazyLock<prometheus::IntGauge> = LazyLock::new(|| { | ||
| prometheus::register_int_gauge!( |
There was a problem hiding this comment.
I got a complaint from clippy here, it seems that we were not using that function and that was only uncovered by this change.
|
@hackpk Thank you very much for your contribution. I took the freedom to make a small update on this PR so that it can be merged as soon as possible. |
ghost
added this pull request to the
|
@near-bookrock thank you |
3 participants
Fix #519
@netrome Please review. Thanks for helping, and apologies for the unwanted changes.