chore(deployment): gcp start bash script: avoid unnecessary warning#707
Merged
kevindeforth merged 1 commit intomainfrom Jul 24, 2025
Merged
chore(deployment): gcp start bash script: avoid unnecessary warning#707kevindeforth merged 1 commit intomainfrom
kevindeforth merged 1 commit intomainfrom
Conversation
andrei-near
approved these changes
Jul 24, 2025
netrome
approved these changes
Jul 24, 2025
Collaborator
netrome
left a comment
netrome
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing the bash script in devnet, we get this warning:
The warning suggests that the node would set
near_responder_account_idto$MPC_ACCOUNT_ID, but this only happens in case if the mpc config file does not already exist.In our devnet test suite, terraform provides the mpc config file, thus, the fallback does not apply. In that context, this error message is slightly confusing, because it insinuates that the variable
near_responder_account_idset by the devnet test suite would be ignored.This PR moves the parsing of the variable inside the function where it is actually used, thus ensuring that the warning will only show in case no mpc config is found on disk.