chore(devnet): Add support for voting new approved code hash on devnet#742
Merged
4 commits merged intomainfrom Jul 31, 2025
Merged
Conversation
ghost
self-assigned this
ghost
force-pushed
the
701-task-add-support-for-voting-new-approved-code-hash-on-devnet
branch
from
5299558 to
b6ffb85
Compare
Contributor
kevindeforth
left a comment
kevindeforth
left a comment
There was a problem hiding this comment.
I would approve, if it wasn't for the small contract code change. I think we should have either the deref trait, or a getter, but not both at the same time.
Author
Fair. It requires more extensive refactoring to remove it, so I created a tracking issue. #744 I'll undo the change. |
…for-voting-new-approved-code-hash-on-devnet
kevindeforth
approved these changes
Jul 31, 2025
ghost
marked this pull request as ready for review
ghost
deleted the
701-task-add-support-for-voting-new-approved-code-hash-on-devnet
branch
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #701
Tested manually that voting a new image hash works:
https://testnet.nearblocks.io/txns/4A2NTyTQPWu67Bmmf4yuUaMVdAXZsmxxxqYtYydafk7j