fix: propose join and rename to submit_participant_info#851
fix: propose join and rename to submit_participant_info#851kevindeforth merged 5 commits intomainfrom
Conversation
netrome
left a comment
netrome
left a comment
There was a problem hiding this comment.
Good stuff! Love these small reviews and clear issues. Makes it so much easier to squeeze in a small PR review before lunch 🤩
Would love to see tests for this, but I see you created a follow-up for that already since it requires the attestation module to be integrated. #846
Otherwise, just one question about a clone.
ghost
removed this pull request from the 
|
@near-bookrock - why did you remove this PR from the merge queue? |
I wanted to have time to also review before it got merged. https://nearone.slack.com/archives/C0912BTG51T/p1755252073726839?thread_ts=1755250728.252599&cid=C0912BTG51T. It was opened at 11:38 GMT+2 and moved to merge queue at 11:54 GMT+2, so there wasn't much time to review if I also wanted to take a look. |
I see, fair enough.
Yep, this is the gold standard imo. Small PRs and quick review turnaround. Nothing wrong with post-merge reviews and follow-ups either. But in this case when you're reviewing just as it got added to the merge queue I agree it can be reasonable to hold the merge for a short bit. |
Yeah definitely, Much appreciated @near-bookrock removed it, as it resulted in better and more maintainable code! |
3 participants
Resolves #841 and contract part of #842