chore(tee): remove account key from report data#869
Conversation
1ffaf27 to
847c24e
Compare
847c24e to
9ed1173
Compare
ghost
left a comment
There was a problem hiding this comment.
We'll need to update the assets for quote/collateral/etc. in the tests instead of commenting out the tests.
@barakeinav1 @gilcu3 we need a new quote for this test: mpc/attestation/tests/test_attestation_verification.rs Lines 83 to 85 in 9ed1173 It needs to be generated the way we do it in this PR: mpc/tee_authority/src/tee_authority.rs Lines 259 to 280 in 9ed1173 Could you help me with that, or point me to how I can do it myself? |
…count-key-from-report-data
…hub.com:near/mpc into pab/tee/866-remove-account-key-from-report-data
| let expected_rtmr3 = [ | ||
| 0x90, 0x5f, 0x81, 0x71, 0x7d, 0x9, 0x5f, 0x14, 0xf5, 0x94, 0x47, 0xed, 0xff, 0xe3, | ||
| 0x3e, 0x1e, 0x3c, 0xe4, 0x85, 0xda, 0xaa, 0x95, 0x3a, 0xc6, 0xfe, 0xb8, 0x21, 0x7f, | ||
| 0xc6, 0x5a, 0x3d, 0x50, 0xb2, 0x96, 0x2e, 0x41, 0x15, 0xe, 0xb8, 0x53, 0x3b, 0xda, | ||
| 0xbe, 0xb2, 0x35, 0x49, 0x31, 0x34, | ||
| ]; | ||
| assert_eq!(td_report.rt_mr3, expected_rtmr3,); |
There was a problem hiding this comment.
I removed this sanity check, as it was effectively testing the dcap crate, and not our code.
Co-authored-by: barakeinav1 <barakeinav@gmail.com> Co-authored-by: Daniel Sharifi <daniel.sharifi@nearone.org> Co-authored-by: Daniel Sharifi <40335219+DSharifi@users.noreply.github.com>
Fixes #866