chore: use configuration value instead of constant for TEE_UPGRADE_PERIOD#995
Merged
chore: use configuration value instead of constant for TEE_UPGRADE_PERIOD#995
TEE_UPGRADE_PERIOD#995Conversation
This reverts commit 67ed8eb.
netrome
approved these changes
Sep 3, 2025
Collaborator
netrome
left a comment
netrome
left a comment
There was a problem hiding this comment.
Looks good to me. I'm sad that we have to have dynamic configuration for these deadlines/timeouts to be able to test them. Although we'll want to support configuring support for local attestations anyway.
gilcu3
reviewed
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #994
I'm sad that once again we have limitations on what we can put in the contract state structs because of the serde/borsh bounds. We have these bounds because we don't have any interface types and use the contract types directly as return types on the contract method, and the node depends on them.
This means we can't for example use structures such as
Rc+RefCellto store the configuration value, instead of passing down values for every call.See revert commit:
a98c6d9