feat(workspace): remove redundant display_name field

[PierreLeGuen]

Summary

• Remove display_name from Workspace model since id already serves as the immutable identifier
• Make name field updatable instead of immutable
• Add migration V0038 to drop display_name column
• Update all route handlers, services, repositories, and tests

Test plan

• Verify existing workspaces work correctly after migration
• Test updating workspace name via API
• Run e2e tests

Closes #329

[gemini-code-assist]

Summary of Changes

Hello @PierreLeGuen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Workspace model by eliminating the display_name field, which was deemed redundant given the existing id and name fields. The name field now takes on the role of the user-facing, mutable identifier, simplifying the data structure and reducing potential confusion. This change is propagated throughout the application's layers, from the database schema with a new migration, through the data models, repositories, services, and API endpoints, ensuring consistency and a cleaner design.

Highlights

• Redundant Field Removal: The display_name field has been removed from the Workspace model, as the id already serves as an immutable identifier.
• Name Field Updatability: The name field of the Workspace model is now mutable, allowing it to be updated via the API.
• Database Migration: A new database migration (V0038) has been added to drop the display_name column from the workspaces table.
• API and Service Layer Updates: All relevant API route handlers, service methods, repository functions, and tests have been updated to reflect the removal of display_name and the new mutability of the name field.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively removes the redundant display_name field from the Workspace model and transitions the name field to be mutable, which simplifies the data model. The changes are consistently applied throughout the codebase, including updates to models, route handlers, services, repositories, and tests. A database migration to drop the display_name column is also correctly included. Overall, this is a solid refactoring. I have one suggestion to enhance validation consistency for the workspace name.