Conversation
asteny
changed the title
asteny
requested review from
ChessProfessor,
Uburro,
dstaroff,
itechdima,
rdjjke and
theyoprst
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Slurm version from 24.05.7 to 24.11.5 across all Dockerfiles, binding scripts, Helm charts, and the Makefile to keep all images and configurations in sync.
- Bump
SLURM_VERSIONARG in every Slurm-related Dockerfile and the Makefile - Update
nvslurm-plugin-pyxisinstallation to include the new Slurm version - Adjust library soname in
bind_slurm_common.shand update Helm image tags
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| images/worker/slurmd.dockerfile | SLURM_VERSION bumped; pyxis plugin install string updated |
| images/slurm_check_job/slurm_check_job.dockerfile | SLURM_VERSION bumped; pyxis plugin install string updated |
| images/restd/slurmrestd.dockerfile | SLURM_VERSION bumped |
| images/nccl_benchmark/nccl_benchmark.dockerfile | SLURM_VERSION bumped; pyxis plugin install string updated |
| images/login/sshd.dockerfile | SLURM_VERSION bumped; pyxis plugin install string updated |
| images/jail/jail.dockerfile | SLURM_VERSION bumped |
| images/exporter/exporter.dockerfile | SLURM_VERSION bumped |
| images/controller/slurmctld.dockerfile | SLURM_VERSION bumped |
| images/common/scripts/bind_slurm_common.sh | Library soname bumped from 41 to 42 |
| images/accounting/slurmdbd.dockerfile | SLURM_VERSION bumped |
| helm/soperator-activechecks/values.yaml | Updated slurm_check_job and munge image tags |
| helm/slurm-cluster/values.yaml | Updated all Slurm-related image tags |
| Makefile | SLURM_VERSION bumped |
Comments suppressed due to low confidence (2)
images/worker/slurmd.dockerfile:130
- Verify that the apt package for the pyxis plugin is actually versioned with both
${SLURM_VERSION}and${PYXIS_VERSION}. If the repository only publishes it under${PYXIS_VERSION}-1, revert or adjust this string to match the real package version.
apt -y install nvslurm-plugin-pyxis=${SLURM_VERSION}-${PYXIS_VERSION}-1 && \
images/worker/slurmd.dockerfile:129
- [nitpick] The same plugin install logic appears in multiple Dockerfiles; extracting it into a shared script or base image layer would reduce duplication and simplify future version updates.
RUN apt-get update && \
theyoprst
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1020