Merged
Conversation
ChessProfessor
requested review from
Uburro,
asteny,
dstaroff,
itechdima,
rdjjke and
theyoprst
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where image processing silently fails by improving error handling in Slurm job submission scripts. The changes add proper exit code checking and enhance error messages to ensure failures are properly detected and reported.
Key changes:
- Added exit code validation for sbatch command execution
- Improved error handling in job array submission workflow
- Enhanced error messages to distinguish between different failure scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| slurm_submit_array_job.sh | Added exit code checking for sbatch command and improved error message specificity |
| slurm_check_job_entrypoint.sh | Added exit code validation for job array submission script with proper error output display |
Comments suppressed due to low confidence (1)
images/slurm_check_job/slurm_submit_array_job.sh:50
- [nitpick] The error message 'Empty output from sbatch' could be more descriptive. Consider adding context about what this means for the user, such as 'sbatch command succeeded but returned no job ID'.
echo "Empty output from sbatch"
theyoprst
approved these changes
Jul 21, 2025
asteny
approved these changes
Jul 21, 2025
theyoprst
pushed a commit
that referenced
this pull request
Jul 23, 2025
(cherry picked from commit 5f60c69)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.