Speedup populate_jail + don't overwrite existing data#1278
Merged
Conversation
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
2 times, most recently
from
56406fa to
c4e18c4
Compare
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
2 times, most recently
from
63c7d97 to
75d83c5
Compare
rdjjke
requested review from
ChessProfessor,
Uburro,
asteny,
dstaroff,
itechdima and
theyoprst
as code owners
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
from
75d83c5 to
741e94e
Compare
rdjjke
changed the title
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
5 times, most recently
from
3f0a2c0 to
e47ed7b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the jail population process by switching from file-based copying to restic backup/restore and implements logic to avoid overwriting existing jail data unless explicitly requested.
- Replace rclone/rsync with restic for faster jail population
- Add intelligent overwrite protection that checks for existing rootfs content
- Optimize container image by removing unnecessary AWS CLI examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| populate_jail_entrypoint.sh | Refactored to use restic and added conditional population logic |
| populate_jail.dockerfile | Changed base image to restic and modified build process to create restic backup |
| jail.dockerfile | Added jail version tracking |
| install_awscli.sh | Cleanup to remove AWS CLI examples directory |
rdjjke
commented
Jul 31, 2025
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
from
e47ed7b to
e71e551
Compare
rdjjke
force-pushed
the
dont-overwrite-data-from-jail/0
branch
from
e71e551 to
b1c18c4
Compare
asteny
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.