[worker topology controller] initial cm topology until asts not found#1401
Merged
[worker topology controller] initial cm topology until asts not found#1401
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fallback mechanism for worker topology configuration when StatefulSets are not found. The main purpose is to create an initial ConfigMap topology configuration using SlurmCluster specifications when AdvancedStatefulSets haven't been created yet.
Key changes:
- Adds fallback logic to create a temporary StatefulSet based on SlurmCluster spec when no existing StatefulSets are found
- Refactors the
EnsureTopologyConfigMapmethod to use the new fallback mechanism - Adds comprehensive test coverage for the fallback functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/topologyconfcontroller/workertopology_controller.go | Implements fallback StatefulSet creation logic when none exist |
| internal/controller/topologyconfcontroller/workertopology_controller_test.go | Adds comprehensive test coverage for the new fallback mechanism |
Uburro
changed the title
Uburro
requested review from
ChessProfessor,
ali-sattari,
asteny,
dstaroff,
itechdima,
rdjjke and
theyoprst
as code owners
dstaroff
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.