fix patch cm with empty labels#1507
Merged
Uburro merged 1 commit intosoperator-release-1.21from Aug 29, 2025
Merged
Conversation
Uburro
requested review from
ChessProfessor,
asteny,
dstaroff,
itechdima,
rdjjke and
theyoprst
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential nil pointer dereference when patching ConfigMaps that have empty or nil labels by ensuring the Labels map is initialized before copying labels from the source.
- Adds nil check and initialization for the Labels map in the ConfigMap patch operation
- Prevents runtime panics when copying labels to ConfigMaps with nil Labels
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
theyoprst
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential nil pointer dereference when patching ConfigMaps that have empty or nil labels by ensuring the Labels map is initialized before copying labels from the source.
Adds nil check and initialization for the Labels map in the ConfigMap patch operation
Prevents runtime panics when copying labels to ConfigMaps with nil Labels