Set driftDetection.mode: warn by default for helm releases#1669
Merged
ali-sattari merged 2 commits intomainfrom Oct 22, 2025
Merged
Set driftDetection.mode: warn by default for helm releases#1669ali-sattari merged 2 commits intomainfrom
driftDetection.mode: warn by default for helm releases#1669ali-sattari merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables FluxCD drift detection in "warn" mode for all Helm releases, allowing the system to emit Kubernetes events when resources drift from their desired state without automatically correcting them. This provides visibility into configuration drift while maintaining manual control over corrections.
Key Changes:
- Set
driftDetection.mode: warnas the default for all Helm release configurations in values.yaml - Created a reusable Helm template helper for drift detection configuration
- Updated all HelmRelease templates to use the new drift detection helper
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| helm/soperator-fluxcd/values.yaml | Added driftDetection configuration with mode: warn to all component definitions |
| helm/soperator-fluxcd/templates/_helpers.tpl | Introduced a helper template for standardized drift detection configuration |
| helm/soperator-fluxcd/templates/*.yaml | Updated all HelmRelease templates to include drift detection using the new helper |
| helm/soperator-fluxcd/templates/victoria-metrics-operator-crds.yaml | Replaced hardcoded drift detection with template helper |
| helm/soperator-fluxcd/templates/mariadb-operator-crds.yaml | Replaced hardcoded drift detection with template helper |
| fluxcd/base/soperator-fluxcd/resources.yaml | Changed drift detection mode from "enabled" to "warn" for the base resource |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
asteny
previously approved these changes
Oct 22, 2025
Uburro
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need to check whether K8S resources have drifted from helm releases (chart + value).
Solution
We can make use of FluxCD drift detection by setting it to warn, so it emit K8S events on detected drifts.
Testing
Release Notes
Setting
driftDetection.mode: warnby default for helm releases in FluxCD.