Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for custom Slurm configuration by introducing a new customSlurmConfig field. This allows users to provide additional Slurm configuration that will be rendered as a multiline string in the SlurmCluster custom resource.
Key Changes:
- Added
customSlurmConfigfield to values.yaml with empty string default - Added template logic to render
customSlurmConfigas a multiline YAML block when provided
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm/slurm-cluster/values.yaml | Adds new customSlurmConfig configuration field |
| helm/slurm-cluster/templates/slurm-cluster-cr.yaml | Adds template rendering logic for customSlurmConfig field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uburro
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
adds support for custom Slurm configuration by introducing a new customSlurmConfig field.