SCHED-380: Skip maintenance handling based on node labels#1773
Merged
ali-sattari merged 3 commits intomainfrom Nov 17, 2025
Merged
SCHED-380: Skip maintenance handling based on node labels#1773ali-sattari merged 3 commits intomainfrom
ali-sattari merged 3 commits intomainfrom
Conversation
asteny
reviewed
Nov 14, 2025
asteny
approved these changes
Nov 14, 2025
268b105 to
5e45836
Compare
rdjjke
approved these changes
Nov 14, 2025
5e45836 to
77da62a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Soperator's handling of maintenance events is geared toward worker nodes and works by deleting the node to be recreated. For non-replicated stateful applications such as NFS we want to stop/start the node instead. Managed K8S control plane already handles maintenance the way we need for these applications.
Solution
Get a list of labels as input and ignore matching nodes when there is a maintenance condition.
Testing
slurm.nebius.ai/nodeset=nfssoperator-check-checksdeploymentkubectl proxyandcurl(example below)skipping draincondition processing due to ignored labelsin logsManually setting node condition:
Log line example:
Release Notes
Skip maintenance handling based on node labels. Useful to let other controllers (such as mk8s in Nebius) handle maintenance events.