NOTIC: Don't use sudo in all-reduce-perf-nccl-in-docker#1846
Merged
rdjjke merged 1 commit intosoperator-release-1.23from Nov 25, 2025
Merged
NOTIC: Don't use sudo in all-reduce-perf-nccl-in-docker#1846rdjjke merged 1 commit intosoperator-release-1.23from
rdjjke merged 1 commit intosoperator-release-1.23from
Conversation
theyoprst
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
all-reduce-perf-nccl-in-dockeractive check doesn't work because the docker image it uses doesn't havesudo.Solution
Get rid of
sudo-- it's not needed in this check.Testing
Create a cluster and make sure this active check works.
Release Notes
Nothing