do not always undrain node#2113
Merged
itechdima merged 1 commit intosoperator-release-2.0from Feb 2, 2026
Merged
Conversation
itechdima
force-pushed
the
SCHED-869/do-not-always-undrain-node
branch
2 times, most recently
from
b8179db to
394302f
Compare
itechdima
force-pushed
the
SCHED-869/do-not-always-undrain-node
branch
from
394302f to
fc4fbca
Compare
Uburro
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
K8S nodes are always undrained by our nodeconfigurator. So in case of k8s needs to replace node softly with drain, our configurator interferes in that flow and doesn't allow it. Also, there's a race with node restarts, so instead of restarting one time it could go several times in a row.
Solution
Testing
Dev cluster
Release Notes
Fix: race during node restart process. Now nodes are restarted only once.
Fix: nodeconfigurator undrains k8s nodes only after restart and once.