Merged
Conversation
This led to some refactoring of ConfigMap mount system. Will be deprecated after introduction of config controller (soon), but allows testing Slurm topologies right now. Now ConfigMaps and Secrets are mounted to some containers via projection, which allows multiple files to appear in the same directory. /etc/slurm is now read-only in all contexts.
webconn
requested review from
Uburro,
asteny,
dstaroff,
itechdima and
rdjjke
as code owners
Uburro
previously approved these changes
Mar 5, 2025
rdjjke
previously approved these changes
Mar 5, 2025
rdjjke
reviewed
Mar 5, 2025
rdjjke
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This led to some refactoring of ConfigMap mount system. Will be deprecated after introduction of config controller (soon), but allows testing Slurm topologies right now.
Now ConfigMaps and Secrets are mounted to some containers via projection, which allows multiple files to appear in the same directory.
/etc/slurm is now read-only in all contexts.