#618: [Speedup] Disable ldconfig on nvidia driver configuration.#634
Merged
#618: [Speedup] Disable ldconfig on nvidia driver configuration.#634
Conversation
theyoprst
force-pushed
the
issue-618/flock-ldconfig
branch
from
c95bef2 to
5e29d41
Compare
theyoprst
added
bug
theyoprst
requested review from
Uburro,
asteny,
dstaroff,
itechdima and
rdjjke
as code owners
theyoprst
changed the title
asteny
previously approved these changes
Apr 2, 2025
asteny
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvidia-container-cli configureruns for 2-2.5s on average and it was run underflockonly to prevent races duringldconfigcalls (it failed which resulted in a pod restart).Since
ldconfigis run separately under otherflock, it was removed from the configuration call with the flock altogether.It should speed up the workers statefulset restart by 2-2.5s multiplied by the number of workers.