NOISSUE: reduction of DebugFlags and removal of the preStop hook#757
Merged
NOISSUE: reduction of DebugFlags and removal of the preStop hook#757
Conversation
Uburro
requested review from
ChessProfessor,
asteny,
dstaroff,
itechdima,
rdjjke and
theyoprst
as code owners
rdjjke
approved these changes
Apr 28, 2025
itechdima
approved these changes
Apr 28, 2025
Uburro
added
ignore-for-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default DebugFlags are reduced to prevent job timeouts on large clusters.
preStop hooks are removed because, when jobs are suspended and workers are restarted, the hooks may deallocate workers still associated with suspended jobs. This leads to controller inconsistencies and failure to recover jobs.
Additionally, preStop hooks are unreliable during instance terminations and kernel panics, where they often do not execute.