Do not lower case for slurm node state (for consistency with jobs).#999
Merged
Do not lower case for slurm node state (for consistency with jobs).#999
Conversation
theyoprst
requested review from
ChessProfessor,
Uburro,
asteny,
dstaroff,
itechdima and
rdjjke
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the slurm node state representation in the exported metrics to use upper-case values, ensuring consistency with job metrics.
- Updated expected metrics in collector_test.go to reflect upper-case node states.
- Removed the call to strings.ToLower in collector.go to retain the original case.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/exporter/collector_test.go | Updated expected metrics to use upper-case base_state values. |
| internal/exporter/collector.go | Removed the lowercasing call on node.BaseState() for consistency. |
itechdima
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#761