Skip to content

Add comment for intentional duplicated monospace font#488

Closed
fritx wants to merge 1 commit into
necolas:masterfrom
fritx:monospace-comment
Closed

Add comment for intentional duplicated monospace font#488
fritx wants to merge 1 commit into
necolas:masterfrom
fritx:monospace-comment

Conversation

@fritx
Copy link
Copy Markdown
Contributor

@fritx fritx commented Nov 7, 2015

#480
https://github.com/necolas/normalize.css#pre-code-kbd-samp

I was confused until I found the answer, so it's better to add this missing comment ;)

@7studio
Copy link
Copy Markdown

7studio commented Nov 9, 2015

👍

@kevinvanrijn
Copy link
Copy Markdown

This should definitely be added. It's pretty obvious that there's confusion why it's there with it being asked at least 12 times now in: #196, #293, #295, #326, #328, #335, #346, #347, #374, #415, #476 and #480.

@fritx
Copy link
Copy Markdown
Contributor Author

fritx commented Nov 13, 2015

wow~ 👍

@battaglr
Copy link
Copy Markdown

battaglr commented Dec 5, 2015

It will certainly reduce the number of issues opened by this. 👍

Comment thread normalize.css
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's spelled "preformatted" with two Ts.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. Just had it copied from here: https://github.com/necolas/normalize.css#pre-code-kbd-samp ..Whatever ;)

@jonathantneal
Copy link
Copy Markdown
Contributor

@fritx, great work. Merged in 5daad01! @KIPdeKIP, @battaglr, there go all the easy issues to close. 😝

@battaglr
Copy link
Copy Markdown

@jonathantneal: awesome! If I can be of any help with the remaining issues, just let me know!

@jonathantneal
Copy link
Copy Markdown
Contributor

Thanks, @battaglr! I’m trying to resolve every PR from oldest to newest. If you want to tackle any one of them, let me know. Then we move onto issues.

@fritx
Copy link
Copy Markdown
Contributor Author

fritx commented Jun 3, 2016

Awesome!

@HelderMagalhaes
Copy link
Copy Markdown

Just bumped into this. Seeing duplicated default classes in optimized CSS files is unexpected, so I ended up here on investigating. A straight duplication is intentional comment next to monospace, monospace occurrences was better IMO to avoid confused users and erroneous error reports. Should an additional issue be created or could this still "fit" this 5yo one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants