Remove optional quotes from CSS attribute selectors#556
Conversation
|
@antibland, hi! IMO that kind of optimizations should be performed by minifiers. |
|
@battaglr Maybe minifiers should do this, but there is no guarantee that all will. Also, This repo appears to be something of a starting point for new projects. Omitting the quotes is a style choice and shaves a few extra bytes. |
|
@antibland, I'm sorry if I was a bit blunt. This is indeed just a matter of style choice. This project uses an explicit style guideline and an implicit one. That being said, if we were up to do simple things that would save a few bites, we could avoid the last semi-colon in a rule, or avoid leaving spaces between the selector and the bracket. But I think that's the job of a minifier, not our job. In any case, remember that the size of "author" code rarely matters; but if you were comparing the two versions, would be fair to compare the gzipped size:
IMO in this context 4 bytes are no real difference. |
No description provided.