Skip to content

Update normalize.css#709

Closed
vanthome wants to merge 1 commit into
necolas:masterfrom
vanthome:patch-1
Closed

Update normalize.css#709
vanthome wants to merge 1 commit into
necolas:masterfrom
vanthome:patch-1

Conversation

@vanthome
Copy link
Copy Markdown
Contributor

The same rule selector b, strong is used twice which causes problems in some scenarios and does not match the convention in the rest of the code. I have merged both rules under one selector.

The same rule selector `b, strong` is used twice which causes problems in some scenarios and does not match the convention in the rest of the code. I have merged both rules under one selector.
@jonathantneal
Copy link
Copy Markdown
Contributor

Hey @vanthome, thanks for looking through the code of this project. Did you see the comment next to the line in question?

Prevent the duplicate application of bolder by the next rule in Safari 6.

This duplication is purposeful.

You did not specify problems in some scenarios, so could you be more specific about this issue?

You also said this does not match the convention in the rest of the code. There are other parts of the code that do similar things, and I assure you we get many issues and PRs for the duplicate monospace, monospace. 😄

Again, it’s awesome that you are looking into the code, and that you would take the time to make a clean PR that only affects the parts of the code you want to change.

My two cents; do not merge.

@vanthome
Copy link
Copy Markdown
Contributor Author

@jonathantneal ok, now I understand the comment and code. I withdraw the PR.

@vanthome vanthome closed this Nov 14, 2017
@vanthome vanthome deleted the patch-1 branch November 14, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants