Add html5 display-role reset for main element#758
Closed
MadeByMike wants to merge 1 commit into
Closed
Conversation
Old versions of IE once required a bunch of html5 elements display to be set to block. The browsers that required this are possibly out of scope, however, since the `main` element was added later, a reset is still required for this element in IE11. See: necolas#727
GarethPW
approved these changes
Oct 23, 2018
GarethPW
left a comment
GarethPW
left a comment
There was a problem hiding this comment.
This is still a very necessary addition, given IE’s remaining install base.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old versions of IE once required a bunch of html5 elements display to be set to block. The browsers that required this are possibly out of scope, however, since the
mainelement was added later, a reset is still required for this element in IE11. See: #727