Removes spin buttons to move the value up or down on input[type=number]#91
Closed
sunny wants to merge 1 commit into
Closed
Removes spin buttons to move the value up or down on input[type=number]#91sunny wants to merge 1 commit into
sunny wants to merge 1 commit into
Conversation
Owner
|
This isn't something that I'm keen on removing as it doesn't really have any negative consequences that I can think of. You haven't provided any reasoning to justify this change. For future reference, I've create a wiki page of guidelines on contributing to normalize.css. Thanks |
Author
|
Sorry about not giving any extra reasoning. Spin buttons are cumbersome when trying to style inputs evenly across browsers, just like the default styles applied to search (which are normalized). Keeping them makes you go through these hoops to make good looking styles in webkit :
As much as I like the idea of adding helper controls and better defaults in browsers, this is a style I always end up adding... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.