Enhance KeyManager with key info retrieval methods and update version to 0.1.4#16
Merged
Enhance KeyManager with key info retrieval methods and update version to 0.1.4#16
Conversation
…al from data and PEM strings
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the KeyManager functionality by adding new methods for retrieving key information from raw data and PEM strings, alongside updating the CLI version to 0.1.4.
- Added
getKeyInfo(fromData:)andgetKeyInfo(fromPEM:)methods for flexible key information retrieval - Enhanced documentation with detailed examples and PEM format support descriptions
- Updated version number from 0.1.3 to 0.1.4
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/SwiftKeyGenCLI/main.swift | Updates version string to 0.1.4 |
| Sources/SwiftKeyGen/Core/KeyManager.swift | Adds new key info retrieval methods and comprehensive documentation updates |
| README.md | Documents the new getKeyInfo method variants in usage examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+430
to
+432
| let data = try Data(contentsOf: URL(fileURLWithPath: expandedPath)) | ||
|
|
||
| return try getKeyInfo(fromData: data) |
There was a problem hiding this comment.
The refactored getKeyInfo(keyPath:) method now assumes all key files are UTF-8 encoded PEM strings, which may not be true for binary key formats. This could break existing functionality for users with non-PEM key files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce additional methods in KeyManager for retrieving key information from data and PEM strings, improving flexibility in key management. Update the version to 0.1.4.