Skip to content

fix(api): ensure posts are cascade deleted on author_id, conversation_id, parent_id #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nednella merged 2 commits into from
Nov 4, 2025
Merged

fix(api): ensure posts are cascade deleted on author_id, conversation_id, parent_id #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a466880
Cascade delete posts on authors/conversations/parents
straightforeward35578 Nov 4, 2025
90b6d4d
Add cascade delete integration test to PostRepositoryIT
straightforeward35578 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api/src/main/resources/db/migration/V1__init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ CREATE TABLE posts (
author_id UUID NOT NULL,
text VARCHAR(280) NOT NULL,
created_at TIMESTAMPTZ NOT NULL DEFAULT CURRENT_TIMESTAMP,
CONSTRAINT fk_parent_id FOREIGN KEY (parent_id) REFERENCES posts(id),
CONSTRAINT fk_conversation_id FOREIGN KEY (conversation_id) REFERENCES posts(id),
CONSTRAINT fk_author_id FOREIGN KEY (author_id) REFERENCES profiles(id)
CONSTRAINT fk_parent_id FOREIGN KEY (parent_id) REFERENCES posts(id) ON DELETE CASCADE,
CONSTRAINT fk_conversation_id FOREIGN KEY (conversation_id) REFERENCES posts(id) ON DELETE CASCADE,
CONSTRAINT fk_author_id FOREIGN KEY (author_id) REFERENCES profiles(id) ON DELETE CASCADE
);

CREATE TABLE post_likes (
Expand Down
13 changes: 13 additions & 0 deletions apps/api/src/test/java/com/example/echo_api/modules/post/repository/PostRepositoryIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,4 +555,17 @@ void PostRepository_FindPostsMentioningProfileId_ContainsOnlyPostsMentioningUser
}
}

@Test
void PostRepository_Delete_CascadeDeletesRelatedPosts() {
Post root = createPost(null, self.getId(), "root.");
Post replyToRoot = createPost(root.getId(), self.getId(), "reply to root.");
Post replyToReply = createPost(replyToRoot.getId(), self.getId(), "reply to reply.");

postRepository.delete(root);

assertFalse(postRepository.existsById(root.getId()));
assertFalse(postRepository.existsById(replyToRoot.getId()));
assertFalse(postRepository.existsById(replyToReply.getId()));
}

}
Loading