adds rac contact details by DarrellRoberts · Pull Request #228 · need4deed-org/fe

DarrellRoberts · 2026-02-13T16:24:36Z

Description

Adds Agent/RAC Contact Details

Related Issues

Closes issue 219

Changes

New hook for updating contact details
New component for RAC Contact Details

Screenshots / Demos

As we don't have "role" and "landline" in the database yet, I had to mock a handler in the backend. Also I had some conflicts with the existing PATCH /person/:id, due to the lack of address on the form.

With this handler, you can successfully edit the details of: firstName, middleName, lastName, email and mobile.

However, if you want to successfully edit role or landline, you'll get a mock success response, but you won't be able to see the updated role/landline in the form.

src/server/routes/person.routes.ts

fastify.patch<{
    Params: ParamsId;
    Reply: ReplyData<ApiPersonGet>;
    Body: ApiPersonPatch;
  }>(
    "/:id",
    {
      schema: {
        params: idParamSchema,
        body: { $ref: "ApiPersonPatch#" },
        // response: responseSchema("ApiPersonGet#"),
        response: {
          200: {
            type: "object",
            properties: {
              message: { type: "string" },
              data: personResponseSchema,
            },
            required: ["message", "data"],
          },
        },
      },
    },
    async (request, reply) => {
      const personId = request.params.id;
      const body = request.body as any;

      if (body.role || body.landline) {
        const mockData = {
          id: personId,
          firstName: body.firstName || "Mock",
          lastName: body.lastName || "User", 
          ...body,
          updatedAt: new Date().toISOString(),
          createdAt: new Date().toISOString(), 
        };

        return reply.status(200).send({
          message: "Mock Update Successful",
          data: mockData,
        });
      } else {
        const person = await fastify.db.personRepository.findOne({
          where: { id: personId },
          // relations: ["address.postcode"],
          relations: [],
        });

        if (!person) {
          throw new NotFoundError(`Person with id ${personId} not found.`);
        }

        const updatedPersonObj = deepMerge(
          {
            id: person.id,
            // addressId: person.addressId,
            // address: { postcodeId: person.address.postcodeId },
          },
          dtoParsePerson(request.body),
        );

        const updatedPerson = await updatePerson(updatedPersonObj);

        const serializedData = dtoSerializePerson(updatedPerson);

        const data = {
          ...person,
          ...serializedData,
          address: null,
          createdAt: person.createdAt || new Date().toISOString(),
          updatedAt: new Date().toISOString(),
        };

        return reply
          .status(200)
          .send({ message: "Person updated successfully.", data });
      }
    },
  );

I added this to person entity for now:

src/data/entity/person.entity.ts

  @IsOptional()
  role?: string[];

  @IsOptional()
  @IsString()
  landline?: string;

I didn't add this, I just commented out any reference to the address in the updatePerson for now

src/server/utils/data/for-routes.ts

export async function updatePerson(
  person: DeepPartial<Person>,
): Promise<Person> {
  const personRepository = getRepository(dataSource, Person);

  // if (Object.keys(person.address || {}).length > 1) {
  //   await updateAddress(person.address);
  // }

  await personRepository.save(person);

  return (await personRepository.findOne({
    where: { id: person.id! },
    // relations: ["address.postcode"],
    relations: [],
  })) as Person;
}

I tweaked the Person Schema to include Role and Landline for now

src/server/schema/person.schema.ts

    role: { type: "string" },
    landline: { type: ["string", "null"] },
  },
};

Checklist

WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
Tests added/updated
Documentation updated
CI passes

HansKre · 2026-02-14T10:47:06Z

src/app/[lang]/dashboard/racs/[id]/page.tsx

+import { apiPathPerson } from "@/config/constants";
+import { useParams } from "next/navigation";
+
+export default function RacsPage() {


What do you think of using /agents/:id instead? Is this the same as this page: src/app/[lang]/dashboard/agents/[id]/page.tsx?

HansKre · 2026-02-14T16:47:23Z

On another note: Since there is a contact details section for the volunteer as well as the opportunity, you might want to consider matching it. src/components/Dashboard/Profile/sections/ContactDetails/ContactDetails.tsx is a good starting point.

DarrellRoberts · 2026-02-16T11:32:34Z

hey @HansKre , thank you for your feedback & both very good points. I've now rebased and refactored the agent contact details so that I'm using the /agents/:id page, useAgentProfileSection hook and the /ContactDetails/ContactDetails.tsx component

HansKre

Looks pretty good. A few comments, only because codebase has changed quite a bit since you started working on the ticket. Sorry for the inconvenience.

HansKre · 2026-02-16T21:53:42Z