fix: prevent left nav bar from overlapping dashboard content#326
Open
Cy-fox wants to merge 3 commits intoneed4deed-org:developfrom
Open
fix: prevent left nav bar from overlapping dashboard content#326Cy-fox wants to merge 3 commits intoneed4deed-org:developfrom
Cy-fox wants to merge 3 commits intoneed4deed-org:developfrom
Conversation
Contributor
|
Victor this PR is picking up all the middleware changes from #319 (default language + cookie persistence) because it looks like it was branched off that branch instead of main. The actual fix here (the |
Cy-fox
force-pushed
the
fix/left-menu-blocking-dashboard-324
branch
from
d31a9ff to
12f9769
Compare
Use CSS max() to clamp the left margin to the sidebar width on narrow viewports, so the fixed navigation bar never hides the search bar or list area. Closes need4deed-org#324.
After testing, the sidebar edge was still clipping the leftmost character of list column headers. Add 16px to the clamped left margin — matching the nav bar's own horizontal padding — to give content a clear visual gap from the sidebar.
Several types were renamed or restructured in the SDK bump that merged with develop, leaving the codebase in a broken state where tsc --noEmit fails on every branch: - AgentCard: use extracted `volunteerSearch` (not agent.volunteerSearch which doesn't exist on ApiAgentGetList) - helpers (Agents): add fallback for volunteerSearch being undefined - statusMaps: SDK enums (e.g. VolunteerStateEngagementType and AgentEngagementStatusType) share the same string values, making object-literal duplicate-key errors unavoidable; switch to Object.fromEntries so last-write-wins logic is preserved without compile errors - AccompanyingDetails helpers: languageToTranslate is now number in SDK, convert to string for the form - AgentContactDetails: representative → representatives[0] (field renamed to plural array in SDK) - useUpdateAgentContact / useUpdateOrganizationDetails: ApiRepresentativePatch removed from SDK; use ApiRepresentativeGet (same shape for patching)
Cy-fox
force-pushed
the
fix/left-menu-blocking-dashboard-324
branch
from
7514604 to
c930313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max()to setmargin-leftto whichever is larger: the sidebar width or the centred layout offset, so content is always pushed clear of the nav barCloses #324