Skip to content

391: adds deserializeFilterFunc to Opp, Vol and Agents lists#398

Merged
need4deed merged 1 commit intodevelopfrom
fix-deserialize-function-in-lists
Apr 25, 2026
Merged

391: adds deserializeFilterFunc to Opp, Vol and Agents lists#398
need4deed merged 1 commit intodevelopfrom
fix-deserialize-function-in-lists

Conversation

@DarrellRoberts
Copy link
Copy Markdown
Collaborator

Description

Adds deserialize functions to following components: components/Dashbaord/Agents/Agents.tsx, components/Dashbaord/Opportunities/Opportunities.tsx, components/Dashbaord/Volunteers/Volunteers.tsx

Related Issues

Closes #391

Changes

  • Bullet list of meaningful changes (optional)

Screenshots / Demos

Before refresh
image


After refresh
image

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

@DarrellRoberts DarrellRoberts self-assigned this Apr 24, 2026
Copy link
Copy Markdown
Collaborator

@nadavosa nadavosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix — the three lists were all missing deserialization of URL params after API filter options loaded, so deep-linking into a filtered view didn't work. Adding searchParams to the dependency arrays is correct.

The rename from deserializeFiltersdeserializeVolunteerFilters is clean and consistent with the naming of the other two functions. LGTM.

@need4deed need4deed merged commit ddcc7a7 into develop Apr 25, 2026
1 check passed
@need4deed need4deed deleted the fix-deserialize-function-in-lists branch April 25, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix and implement deserialize function in List components on dashboard

3 participants