Pass event object to button click handlers.#235
Merged
needim merged 1 commit intoneedim:masterfrom Dec 25, 2014
greenjoe:buttons-click-event-pass
Merged
Pass event object to button click handlers.#235needim merged 1 commit intoneedim:masterfrom greenjoe:buttons-click-event-pass
needim merged 1 commit intoneedim:masterfrom
greenjoe:buttons-click-event-pass
Conversation
Button click handlers should have access to original event objects. It is sometimes useful, for example to call .preventDefault(). This commit passes event object as an additional argument in the click handler call. It shouldn't break any existing code.
needim
added a commit
that referenced
this pull request
Dec 25, 2014
Pass event object to button click handlers.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button click handlers should have access to original event objects.
It is sometimes useful, for example to call .preventDefault().
This commit passes event object as an additional argument in the click handler call.
It shouldn't break any existing code.