feat: download-attachments for comments & documents, shared download helper#148
Merged
brigleb merged 3 commits intoneedmore:mainfrom Feb 24, 2026
Merged
Conversation
…nload helper - Add `comment download-attachments` and `document download-attachments` commands - Add `--include-comments` flag to card/todo/message/document download-attachments - Extract shared `internal/download` package, eliminating ~450 lines of duplication - Show attachments in `comment view` output - Add comprehensive tests for the shared download helper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@brigleb - some more enhancements for my AI agents to use 😊 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new CLI support for downloading attachments from additional Basecamp resource types while consolidating shared download logic into a reusable internal helper.
Changes:
- Introduces
bc4 comment download-attachmentsandbc4 document download-attachmentscommands. - Adds
--include-commentsto existing download-attachments commands (card/todo/message/document) to also fetch attachments from comments. - Extracts shared attachment download logic into
internal/downloadwith accompanying unit tests; updates README + CHANGELOG.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/download/download.go | New shared helper to parse attachment HTML and download uploads with consistent CLI output and summary. |
| internal/download/download_test.go | Unit tests for the shared helper (multi-source, overwrite/skip behavior, attachment indexing, blob URL handling, helpers). |
| internal/api/pagination.go | Minor formatting cleanup in PaginatedRequest struct alignment. |
| cmd/card/download_attachments.go | Replaces in-command download logic with shared helper; adds --include-comments. |
| cmd/todo/download_attachments.go | Replaces in-command download logic with shared helper; adds --include-comments. |
| cmd/message/download_attachments.go | Replaces in-command download logic with shared helper; adds --include-comments. |
| cmd/document/download_attachments.go | New document attachment download command (with --include-comments). |
| cmd/document/document.go | Registers the new document download-attachments subcommand. |
| cmd/comment/download_attachments.go | New comment attachment download command. |
| cmd/comment/comment.go | Registers the new comment download-attachments subcommand. |
| cmd/comment/view.go | Adds attachment display to comment view output (matching other view commands). |
| README.md | Documents new commands and --include-comments; updates blob URL limitation guidance. |
| CHANGELOG.md | Adds Unreleased entries for new commands/flag and refactor. |
…test cleanup - Deduplicate filenames when multiple attachments share the same name (e.g., image.png → image_1.png) - Reject Windows-reserved device names (CON, PRN, NUL, COM1-9, LPT1-9) in SanitizeFilename - Fix os.Getwd() error handling in test, use t.Cleanup for directory restore - Add tests for deduplication and Windows reserved names Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Blob storage URLs are expected to be undownloadable via OAuth and shouldn't cause a non-zero exit code. They're now counted as skipped with a warning, matching the existing file-exists skip behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
comment download-attachmentsanddocument download-attachmentscommands so attachments can be downloaded from any Basecamp resource type. Add--include-commentsflag to card, todo, message, and document download-attachments to also pull attachments from comments on those resources.internal/downloadpackage withDownloadFromSources()helper, eliminating ~450 lines of near-identical code across the three existing download commandsbc4 comment download-attachments <id|url>— download attachments from a commentbc4 document download-attachments <id|url>— download attachments from a document--include-commentsflag on card/todo/message/document download-attachments fetches comment attachments too, with[source label]prefixes to identify where each file came fromcomment viewoutput (matches existing card/todo view behavior)