fix pagination state and past members styling#15
Merged
Conversation
- LastSeen: reference propClassName instead of undefined className in the Online branch (fixes build error, applies gray styling to online past members) - ClanPlayerCount: parse past param the same way as the server/toggle (past === 'true' || '1') so the header total stays consistent Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey again! thanks for merging the previous pr so quickly! while testing the new 'show past members' feature on some edge cases, i noticed a few ux glitches that i wanted to polish up in this follow-up pr.
first, the pagination state was getting lost: clicking next page would drop the past=true parameter, and checking the box would throw you back to page 1. now both elements preserve the full url state properly. second, i added a redirect fallback: if you uncheck the box while on a high page number (where the active members list wouldn't reach), it will automatically redirect you to the last available page instead of showing an empty list. finally, i improved the styling by making the entire row grayed out for past members instead of just their name, and added the total historical player count in gray next to the active player count in the header.
hope this makes the feature feel even more polished and native!
ON:
OFF:
