Skip to content

Conversation

@mdmzfzl
Copy link
Collaborator

@mdmzfzl mdmzfzl commented Aug 7, 2023


@mdmzfzl mdmzfzl merged commit 8945086 into neetcode-gh:main Aug 7, 2023
@mdmzfzl mdmzfzl linked an issue Aug 7, 2023 that may be closed by this pull request
@neetcode-gh
Copy link
Owner

Hi, I know that this commit simplifies the code, but users prefer the code to be the same as the video. Please don't update existing python solutions unless there is a good reason to do so. Feel free to tag me if needed.

@mdmzfzl

@mdmzfzl
Copy link
Collaborator Author

mdmzfzl commented Sep 20, 2023

Thank you for explaining your preferences. I fully understand the significance of maintaining code consistency with the video and refraining from updating existing Python solutions without a valid reason. I'd like to provide some context though. While I don't usually touch Python code, someone raised an issue indicating that the existing code wasn't passing all test cases. After checking for myself, I indeed found that it was only passing 39 out of 40 test cases. Because of this, I tried to update the solution to improve its performance.
However, I completely understand your point of view and will adhere to your instructions going forward. I won't make any further changes to Python code without a valid reason, and if such a situation arises, I'll ensure to tag you for approval.

Thank you for letting me contribute and if there's anything else please let me know.
@neetcode-gh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas station Python solution

2 participants