Conversation
Show OS-specific install guidance and prevent profile creation until harness is installed.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
- Add copilot-cli|copilot match arm to parse_harness_kind() - Add unit test validating mcp-config.json structure - Test ensures mcpServers.filesystem.command/args exist
- Make resolve_harness() pub(crate) for reuse - Use harness.id() for profile paths and InstallTarget - Add tests verifying copilot alias resolves to copilot-cli - Prevents profile path mismatches (profiles/copilot vs copilot-cli)
- Add npm to installers and publish-jobs in dist-workspace.toml - Add publish-npm job to release workflow - Document NPM_TOKEN setup in CONTRIBUTING.md
Contributor
Greptile SummaryThis PR adds npm publishing support for the Major changes:
Note: The PR title mentions only npm publishing, but includes significant Copilot CLI feature work across 15 commits. The git dependencies in Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Trigger as GitHub Release
participant Plan as plan job
participant Host as host job
participant NPM as publish-npm job
participant Homebrew as publish-homebrew-formula job
participant Announce as announce job
Trigger->>Plan: Trigger on release tag
Plan->>Plan: Parse release plan with cargo-dist
Plan->>Host: Pass plan output
Host->>Host: Build artifacts for all platforms
Host->>Host: Upload artifacts-* (includes -npm-package.tar.gz)
par Parallel Publishing
Host->>NPM: Artifacts ready
NPM->>NPM: Download artifacts-* to npm/
NPM->>NPM: Setup Node.js 20.x
NPM->>NPM: Filter releases with -npm-package.tar.gz
NPM->>NPM: Run npm publish --access public
Note over NPM: Uses NODE_AUTH_TOKEN (NPM_TOKEN secret)
and
Host->>Homebrew: Artifacts ready
Homebrew->>Homebrew: Publish Homebrew formula
end
NPM->>Announce: Success/Skip
Homebrew->>Announce: Success/Skip
Announce->>Announce: Create release announcement
Note over Announce: Only if host succeeded and<br/>publish jobs succeeded or skipped
|
Comment on lines
+15
to
+16
| harness-locate = { git = "https://github.com/neiii/harness-barn", branch = "master" } | ||
| skills-locate = { git = "https://github.com/neiii/harness-barn", branch = "master" } |
Contributor
There was a problem hiding this comment.
logic: Git dependencies pointing to master branch will cause issues for users installing via cargo and for publishing to crates.io. Consider:
- Publishing new versions of
harness-locateandskills-locateto crates.io with Copilot CLI support - Reverting to versioned crate dependencies before releasing
Suggested change
| harness-locate = { git = "https://github.com/neiii/harness-barn", branch = "master" } | |
| skills-locate = { git = "https://github.com/neiii/harness-barn", branch = "master" } | |
| harness-locate = "0.4.0" # or appropriate version with CopilotCli support | |
| skills-locate = "0.3.0" # or appropriate version |
Prompt To Fix With AI
This is a comment left during a code review.
Path: Cargo.toml
Line: 15:16
Comment:
**logic:** Git dependencies pointing to `master` branch will cause issues for users installing via cargo and for publishing to crates.io. Consider:
- Publishing new versions of `harness-locate` and `skills-locate` to crates.io with Copilot CLI support
- Reverting to versioned crate dependencies before releasing
```suggestion
harness-locate = "0.4.0" # or appropriate version with CopilotCli support
skills-locate = "0.3.0" # or appropriate version
```
How can I resolve this? If you propose a fix, please make it concise.
neiii
added a commit
that referenced
this pull request
Jan 16, 2026
* release: v0.2.7 - Add Copilot CLI harness support (#15) - Add npm publishing support (#30) - Switch to versioned crate dependencies (harness-locate 0.4, skills-locate 0.2) * Update CHANGELOG.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bridle-aipackage on releasesChanges
dist-workspace.toml: Addednpmto installers and publish-jobs, setnpm-package = "bridle-ai".github/workflows/release.yml: Addedpublish-npmjob that downloads artifacts and runsnpm publishCONTRIBUTING.md: Documented NPM_TOKEN secret setupBefore merging
Ensure
NPM_TOKENsecret is configured in GitHub repo settings.