CloudFlare email forwarding#10593
Merged
Merged
Conversation
…addresses for a given email
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements email forwarding functionality via CloudFlare along with a refactoring of email processing to use SES. Key changes include:
- New CloudFlare email forwarder service (cloudflare/intercode-email-forwarder.ts) that fetches forwarding addresses.
- Added GET route and controller (config/routes.rb and app/controllers/email_forwarders_controller.rb) to expose email forwarding, secured with token authentication.
- Refactored email delivery service to call the new SES forwarding service and introduced an EmailForwardingRouter to consolidate forwarding logic.
- Extended the release workflow to include a CloudFlare deployment job.
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/controllers/email_forwarders_controller_test.rb | Introduces a new test file with placeholder tests for the EmailForwardersController. |
| config/routes.rb | Adds a new GET route for email forwarders with an email format constraint. |
| cloudflare/intercode-email-forwarder.ts | Implements logic to fetch forward addresses and forward emails via CloudFlare. |
| app/services/receive_sns_email_delivery_service.rb | Refactors service call to use the new SES forwarding service. |
| app/services/forward_email_via_ses_service.rb | Updates email forwarding implementation and logging in SES service. |
| app/services/email_forwarding_router.rb | New service to centralize the email routing logic for forwarding. |
| app/controllers/email_forwarders_controller.rb | New controller to expose email forwarding data with authentication. |
| .github/workflows/release.yml | Adds a CloudFlare release job for deployment. |
Files not reviewed (5)
- .env.development: Language not supported
- cloudflare/.dev.vars: Language not supported
- cloudflare/tsconfig.json: Language not supported
- cloudflare/wrangler.jsonc: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
test/controllers/email_forwarders_controller_test.rb:4
- The test file contains only commented-out placeholder tests. Please add meaningful tests for EmailForwardersController to verify its behavior and authentication logic.
# test "the truth" do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.