Skip to content

CloudFlare email forwarding#10593

Merged
nbudin merged 5 commits into
mainfrom
cloudflare-email-forwarder
Apr 18, 2025
Merged

CloudFlare email forwarding#10593
nbudin merged 5 commits into
mainfrom
cloudflare-email-forwarder

Conversation

@nbudin
Copy link
Copy Markdown
Contributor

@nbudin nbudin commented Apr 18, 2025

No description provided.

@nbudin nbudin marked this pull request as ready for review April 18, 2025 19:30
@nbudin nbudin added the minor Bumps the minor version number on release label Apr 18, 2025
@nbudin nbudin requested a review from Copilot April 18, 2025 19:32
@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 30.58%

Minimum allowed coverage is 0%, this run produced 30.58%

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements email forwarding functionality via CloudFlare along with a refactoring of email processing to use SES. Key changes include:

  • New CloudFlare email forwarder service (cloudflare/intercode-email-forwarder.ts) that fetches forwarding addresses.
  • Added GET route and controller (config/routes.rb and app/controllers/email_forwarders_controller.rb) to expose email forwarding, secured with token authentication.
  • Refactored email delivery service to call the new SES forwarding service and introduced an EmailForwardingRouter to consolidate forwarding logic.
  • Extended the release workflow to include a CloudFlare deployment job.

Reviewed Changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/controllers/email_forwarders_controller_test.rb Introduces a new test file with placeholder tests for the EmailForwardersController.
config/routes.rb Adds a new GET route for email forwarders with an email format constraint.
cloudflare/intercode-email-forwarder.ts Implements logic to fetch forward addresses and forward emails via CloudFlare.
app/services/receive_sns_email_delivery_service.rb Refactors service call to use the new SES forwarding service.
app/services/forward_email_via_ses_service.rb Updates email forwarding implementation and logging in SES service.
app/services/email_forwarding_router.rb New service to centralize the email routing logic for forwarding.
app/controllers/email_forwarders_controller.rb New controller to expose email forwarding data with authentication.
.github/workflows/release.yml Adds a CloudFlare release job for deployment.
Files not reviewed (5)
  • .env.development: Language not supported
  • cloudflare/.dev.vars: Language not supported
  • cloudflare/tsconfig.json: Language not supported
  • cloudflare/wrangler.jsonc: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

test/controllers/email_forwarders_controller_test.rb:4

  • The test file contains only commented-out placeholder tests. Please add meaningful tests for EmailForwardersController to verify its behavior and authentication logic.
  # test "the truth" do

@nbudin nbudin merged commit 5c25f2f into main Apr 18, 2025
17 checks passed
@nbudin nbudin deleted the cloudflare-email-forwarder branch April 18, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Bumps the minor version number on release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants