ForwardEmail.net support

[nbudin]

No description provided.

[Copilot]

Pull Request Overview

This PR adds support for ForwardEmail.net by introducing a new service and job to handle email forwarding, as well as integrating email forwarding sync callbacks into various models. Key changes include:

• Adding the SyncForwardEmailService to handle API interactions with ForwardEmail.net.
• Implementing email forwarding sync callbacks in TeamMember, StaffPosition, Event, EmailRoute, and Convention models.
• Enhancing EmailForwardingRouter with Mapping and MappingSet to consolidate email route mappings.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
app/services/sync_forward_email_service.rb	New service to connect and synchronize domains and aliases with ForwardEmail.net, with a potential loop condition issue in pagination.
app/services/email_forwarding_router.rb	New Mapping and MappingSet classes to assemble email forwarding mappings; potential missing implementation for keys method.
app/models/team_member.rb	Added after_commit callback to trigger email forwarding sync.
app/models/staff_position.rb	Added after_commit callback; potential issue with referencing an undefined association.
app/models/event.rb	Added after_commit callback for email forwarding sync.
app/models/email_route.rb	Added after_commit callback for email forwarding sync with improved normalization methods.
app/models/convention.rb	Updated callback to conditionally trigger email forwarding sync on multiple domain/setting changes.
app/jobs/sync_email_forwarding_for_domain_job.rb	New job to trigger synchronization using the service.
Gemfile	Added Faraday gem to support HTTP connections.

[Copilot]

MappingSet instances do not implement a 'keys' method; consider delegating 'keys' to the underlying mappings hash or adjusting the method accordingly.

[Copilot]

The method references 'convention', which is not defined on StaffPosition; consider using the associated 'catch_all_convention' if that was the intended source.

Suggested change

	SyncEmailForwardingForDomainJob.perform_later(EmailRoute.normalize_domain(convention.domain))
	domain = convention&.domain || catch_all_convention&.domain
	return unless domain
	SyncEmailForwardingForDomainJob.perform_later(EmailRoute.normalize_domain(domain))

[github-actions]

Code Coverage Report: Only Changed Files listed

Package	Coverage
Overall Coverage	🟢 30.61%

Minimum allowed coverage is 0%, this run produced 30.61%

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Faraday::TooManyRequestsError: the server responded with status 429 (Faraday::TooManyRequestsError) SyncForwardEmailService in add_alias View Issue
• ‼️ Faraday::BadRequestError: the server responded with status 400 (Faraday::BadRequestError) SyncForwardEmailService in add_alias View Issue
• ‼️ Faraday::BadRequestError: the server responded with status 400 (Faraday::BadRequestError) SyncEmailForwardingForDomainJob View Issue

_{Did you find this useful? React with a 👍 or 👎}