Naive React Router 7 upgrade (library mode)#10628
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the codebase from React Router v6 (using the react-router-dom package) to React Router v7 (using the react-router package in library mode). The changes mainly consist of updating import statements and removing deprecated or no longer needed future configuration options.
Reviewed Changes
Copilot reviewed 223 out of 223 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/javascript/CmsAdmin/* | Updated react-router-dom imports to react-router imports |
| app/javascript/CmsContentGroupsAdmin/* | Updated react-router-dom imports to react-router imports |
| app/javascript/Authentication/* | Updated react-router-dom imports to react-router imports |
| app/javascript/Breadcrumbs/* | Updated react-router-dom imports to react-router imports |
| app/javascript/AppWrapper.tsx | Removed v7 future configuration options and updated RouterProvider usage |
| Other files | Similar migration of react-router-dom to react-router |
Comments suppressed due to low confidence (1)
app/javascript/AppWrapper.tsx:143
- Verify that removing the v7 future configuration options is intentional, as these flags previously provided enhanced behavior for form handling and data fetching in React Router. If any of these features are needed, consider reintroducing the appropriate configuration.
future: { v7_relativeSplatPath: true, v7_normalizeFormMethod: true, v7_partialHydration: true, v7_skipActionErrorRevalidation: true, v7_fetcherPersist: true, }
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.