Skip to content

Naive React Router 7 upgrade (library mode)#10628

Merged
nbudin merged 2 commits into
mainfrom
react-router-7-minimal
Apr 25, 2025
Merged

Naive React Router 7 upgrade (library mode)#10628
nbudin merged 2 commits into
mainfrom
react-router-7-minimal

Conversation

@nbudin
Copy link
Copy Markdown
Contributor

@nbudin nbudin commented Apr 25, 2025

No description provided.

@nbudin nbudin added the minor Bumps the minor version number on release label Apr 25, 2025
@nbudin nbudin requested a review from Copilot April 25, 2025 17:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the codebase from React Router v6 (using the react-router-dom package) to React Router v7 (using the react-router package in library mode). The changes mainly consist of updating import statements and removing deprecated or no longer needed future configuration options.

Reviewed Changes

Copilot reviewed 223 out of 223 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/javascript/CmsAdmin/* Updated react-router-dom imports to react-router imports
app/javascript/CmsContentGroupsAdmin/* Updated react-router-dom imports to react-router imports
app/javascript/Authentication/* Updated react-router-dom imports to react-router imports
app/javascript/Breadcrumbs/* Updated react-router-dom imports to react-router imports
app/javascript/AppWrapper.tsx Removed v7 future configuration options and updated RouterProvider usage
Other files Similar migration of react-router-dom to react-router
Comments suppressed due to low confidence (1)

app/javascript/AppWrapper.tsx:143

  • Verify that removing the v7 future configuration options is intentional, as these flags previously provided enhanced behavior for form handling and data fetching in React Router. If any of these features are needed, consider reintroducing the appropriate configuration.
future: { v7_relativeSplatPath: true, v7_normalizeFormMethod: true, v7_partialHydration: true, v7_skipActionErrorRevalidation: true, v7_fetcherPersist: true, }

@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 30.86%

Minimum allowed coverage is 0%, this run produced 30.86%

@nbudin nbudin merged commit fd1025a into main Apr 25, 2025
16 checks passed
@nbudin nbudin deleted the react-router-7-minimal branch April 25, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Bumps the minor version number on release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants