Add missing dnsmasq setup instructions for macOS#11437
Merged
Conversation
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The macOS section of the wildcard DNS setup instructions in README.md was missing the actual dnsmasq installation and configuration steps. It jumped straight from setting up the resolver file to testing with
ping, leaving out the critical steps of installing dnsmasq and configuring it to resolve*.intercode.testto127.0.0.1. This would leave someone following the instructions confused about why the ping test doesn't work.Also cleaned up a small inconsistency where Linux and Windows sections described the macOS resolver as supporting "wildcard domain resolution" — it actually does host-specific resolution via resolver files, not wildcards. macOS's resolver mechanism sends queries for a given domain to a specified nameserver, and dnsmasq is still the piece doing the wildcard matching.
Testing
Verified the instructions are complete and accurate by reading through the full setup flow.
🤖 Generated with Claude Code