Skip to content

Conversation

@DennisPeriquet
Copy link

@DennisPeriquet DennisPeriquet commented Jun 8, 2022

Ideas on adding images taken from Egli's PR.

TODO: fix the link that gets a 404; see my comment.

* The [backendDisruptionTest](https://github.com/neisw/origin/blob/0c50d9d8bedbd2aa0af5c8a583418601891ee9d4/test/extended/util/disruption/backend_sampler_tester.go#L34) is responsible for
* Creating the event broadcaster, recorder and monitor
* Attempting to query the backend and timing out after the max interval (1 second typically)
* [Attempting to query the backend](backend_queries.md) and timing out after the max interval (1 second typically)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for feedback on how to fix this. If I click on this link while running hugo, I get a 404.

Copy link
Owner

@neisw neisw Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try

(../backend_queries)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank,I'll give it a whirl soon.

@eggfoobar
Copy link

This is great, in the PR I just opened up, I thought it might make more sense to split the disruption info into its own sub category. Do you guys think we should merge that in, and move this file under that folder? #2

@neisw neisw force-pushed the trt-237-disruption branch from a1e58d1 to 2a532ef Compare June 9, 2022 11:59
@neisw
Copy link
Owner

neisw commented Jun 9, 2022

This is great, in the PR I just opened up, I thought it might make more sense to split the disruption info into its own sub category. Do you guys think we should merge that in, and move this file under that folder? #2

Yes, I just merged in your changes Egli. Dennis can update his branch and we can get that refactored and merged in as well.

@DennisPeriquet
Copy link
Author

my branch has been updated with the latest on trt-237-disruption

@neisw neisw merged commit a559325 into neisw:trt-237-disruption Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants