Skip to content

resolve #20 LoggerTestが肥大化しているので複数のテストに分割 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 7, 2018
Merged

resolve #20 LoggerTestが肥大化しているので複数のテストに分割 #39

merged 15 commits into from
Jun 7, 2018

Conversation

@keitakn
Copy link
Member

@keitakn keitakn commented Jun 7, 2018 •
edited
Loading

issueURL

#20

やった事

  • 大きくなったテストクラスを複数のクラスに分割
  • テストコードのリファクタリング

@keitakn keitakn changed the title [WIP] resolve #20 LoggerTestが肥大化しているので複数のテストに分割する [WIP] resolve #20 LoggerTestが肥大化しているので複数のテストに分割 Jun 7, 2018
@coveralls
Copy link

coveralls commented Jun 7, 2018

Pull Request Test Coverage Report for Build 35

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.436%
Totals Coverage Status
Change from base Build 33: 0.0%
Covered Lines: 114
Relevant Lines: 117
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 43

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.436%
Totals Coverage Status
Change from base Build 33: 0.0%
Covered Lines: 114
Relevant Lines: 117
💛 - Coveralls

keitakn added 13 commits June 7, 2018 11:01
@keitakn
modify #20 separated the test of the "info" method into another class
3fc81dc
@keitakn
fixed #20 mistake fixed
2dbbd4e
@keitakn
modify #20 separated the test of the "debug" method into another class
6271adc
@keitakn
modify #20 separated the test of the "notice" method into another class
52f11f7
@keitakn
modify #20 separated the test of the "warning" method into another class
bfc3b92
@keitakn
add #20 separated the test of the "critical" method into another class
39c1645
@keitakn
modify #20 separated the test of the "alert" method into another class
c701222
@keitakn
modify #20 separated the test of the "emergency" method into another …
1e4d000 
…class
@keitakn
modify #20 separated the test of the "error" method into another class
dadaeef
@keitakn
remove #20 Delete the method moved to another class.
f7692c4
@keitakn
modify #20 refactored the test code.
631d590 
- Variable file name
- Changed to set log file name to output according to log level
@keitakn
modify #20 refactored the test code.
88c5d40 
- Variable file name
- Changed to set log file name to output according to log level
@keitakn
modify #20 refactored the test code. Variable of default log file name
099a7bb
@keitakn keitakn changed the title [WIP] resolve #20 LoggerTestが肥大化しているので複数のテストに分割 resolve #20 LoggerTestが肥大化しているので複数のテストに分割 Jun 7, 2018
@keitakn keitakn merged commit 9f108c4 into master Jun 7, 2018
@keitakn keitakn deleted the feature/issue20 branch June 7, 2018 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keitakn @coveralls